including improved command handling and sync status updates

This commit is contained in:
Mo Tarbin
2026-05-25 01:56:14 -04:00
parent 45e667abf7
commit aece93d63d
10 changed files with 183 additions and 23 deletions

View File

@@ -18,6 +18,14 @@ export const CommandType = {
}
class CommandQueue {
_sanitizeCreatePayload(payload = {}) {
const sanitized = { ...payload }
delete sanitized.id
delete sanitized._pendingCreate
delete sanitized._pendingUpdate
return sanitized
}
// Enqueue a domain command
async enqueue(type, entityId, payload) {
if (!isOfflineFeatureEnabled()) {
@@ -121,17 +129,82 @@ class CommandQueue {
const toRemove = []
for (const cmd of pending) {
const prev = seen.get(cmd.entityId)
if (prev?.commandType === CommandType.CREATE_CHORE) {
if (cmd.commandType === CommandType.UPDATE_CHORE) {
const mergedPayload = this._sanitizeCreatePayload({
...prev.payload,
...cmd.payload,
})
await offlineDB.updateCommand(prev.id, {
payload: JSON.stringify(mergedPayload),
})
toRemove.push(cmd.id)
continue
}
if (cmd.commandType === CommandType.RESCHEDULE_CHORE) {
const mergedPayload = this._sanitizeCreatePayload({
...prev.payload,
dueDate: cmd.payload?.dueDate ?? prev.payload?.dueDate,
nextDueDate: cmd.payload?.dueDate ?? prev.payload?.nextDueDate,
})
await offlineDB.updateCommand(prev.id, {
payload: JSON.stringify(mergedPayload),
})
toRemove.push(cmd.id)
continue
}
if (cmd.commandType === CommandType.ARCHIVE_CHORE) {
const mergedPayload = this._sanitizeCreatePayload({
...prev.payload,
isActive: false,
})
await offlineDB.updateCommand(prev.id, {
payload: JSON.stringify(mergedPayload),
})
toRemove.push(cmd.id)
continue
}
if (cmd.commandType === CommandType.UNARCHIVE_CHORE) {
const mergedPayload = this._sanitizeCreatePayload({
...prev.payload,
isActive: true,
})
await offlineDB.updateCommand(prev.id, {
payload: JSON.stringify(mergedPayload),
})
toRemove.push(cmd.id)
continue
}
if (cmd.commandType === CommandType.DELETE_CHORE) {
toRemove.push(prev.id, cmd.id)
seen.delete(cmd.entityId)
continue
}
}
if (cmd.commandType === CommandType.UPDATE_CHORE) {
const prev = seen.get(cmd.entityId)
if (prev && prev.commandType === CommandType.UPDATE_CHORE) {
// Merge: keep latest payload, remove older
toRemove.push(prev.id)
}
}
if (cmd.commandType === CommandType.DELETE_CHORE) {
if (prev?.commandType === CommandType.UPDATE_CHORE) {
toRemove.push(prev.id)
}
}
seen.set(cmd.entityId, cmd)
}
for (const id of toRemove) {
for (const id of [...new Set(toRemove)]) {
await offlineDB.removeCommand(id)
}
}

View File

@@ -104,15 +104,17 @@ class SQLiteBackend {
})
}
async getChores() {
async getChores(includeArchive = false) {
const result = await CapacitorSQLite.query({
database: DB_NAME,
statement: 'SELECT data FROM cached_chores',
values: [],
})
return (result.values || [])
.map(row => JSON.parse(row.data))
.filter(chore => chore.isActive !== false)
const chores = (result.values || []).map(row => JSON.parse(row.data))
if (includeArchive) {
return chores
}
return chores.filter(chore => chore.isActive !== false)
}
async getChore(id) {
@@ -334,6 +336,35 @@ class SQLiteBackend {
})
}
async updateCommand(id, updates) {
const result = await CapacitorSQLite.query({
database: DB_NAME,
statement: 'SELECT * FROM command_queue WHERE id = ?',
values: [id],
})
if (!result.values?.length) return
const row = result.values[0]
await CapacitorSQLite.run({
database: DB_NAME,
statement: `UPDATE command_queue
SET command_type = ?, entity_id = ?, payload = ?, created_at = ?, status = ?, error = ?
WHERE id = ?`,
values: [
updates.commandType ?? row.command_type,
updates.entityId ?? row.entity_id,
updates.payload ?? row.payload,
updates.createdAt ?? row.created_at,
updates.status ?? row.status,
Object.prototype.hasOwnProperty.call(updates, 'error')
? updates.error
: row.error,
id,
],
})
}
async removeCommand(id) {
await CapacitorSQLite.run({
database: DB_NAME,
@@ -544,10 +575,14 @@ class IndexedDBBackend {
})
}
async getChores() {
async getChores(includeArchive = false) {
const { store } = await this._tx('cached_chores')
const rows = await this._request(store.getAll())
return rows.map(row => row.data).filter(chore => chore.isActive !== false)
const chores = rows.map(row => row.data)
if (includeArchive) {
return chores
}
return chores.filter(chore => chore.isActive !== false)
}
async getChore(id) {
@@ -748,6 +783,19 @@ class IndexedDBBackend {
}
}
async updateCommand(id, updates) {
const { store } = await this._tx('command_queue', 'readwrite')
const row = await this._request(store.get(id))
if (row) {
await this._request(
store.put({
...row,
...updates,
}),
)
}
}
async removeCommand(id) {
const { store } = await this._tx('command_queue', 'readwrite')
await this._request(store.delete(id))
@@ -864,10 +912,10 @@ class OfflineDB {
return this.backend.saveChores(chores)
}
async getChores() {
async getChores(includeArchive = false) {
if (!isOfflineFeatureEnabled()) return []
await this._ensureInit()
return this.backend.getChores()
return this.backend.getChores(includeArchive)
}
async getChore(id) {
@@ -913,6 +961,12 @@ class OfflineDB {
return this.backend.updateCommandStatus(id, status, error)
}
async updateCommand(id, updates) {
if (!isOfflineFeatureEnabled()) return
await this._ensureInit()
return this.backend.updateCommand(id, updates)
}
async removeCommand(id) {
if (!isOfflineFeatureEnabled()) return
await this._ensureInit()

View File

@@ -92,7 +92,7 @@ class SyncEngine {
} else {
// Transient network/server error - reset to pending so it retries
await commandQueue.resetPending(cmd.id)
break
throw err
}
}
}